Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSA4b1 #836

Merged
merged 5 commits into from
Apr 24, 2019
Merged

RSA4b1 #836

merged 5 commits into from
Apr 24, 2019

Conversation

ricardopereira
Copy link
Contributor

@ricardopereira ricardopereira marked this pull request as ready for review March 4, 2019 14:24
SimonWoolf
SimonWoolf approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@SimonWoolf SimonWoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand in what circumstances you have have a time offset set but it doesn't have a value? Otherwise lgtm

@ricardopereira ricardopereira merged commit ffa12b7 into develop Apr 24, 2019
@ricardopereira ricardopereira deleted the rsa4b1 branch April 24, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonWoolf SimonWoolf SimonWoolf approved these changes

@mattheworiordan mattheworiordan Awaiting requested review from mattheworiordan

@paddybyers paddybyers Awaiting requested review from paddybyers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardopereira @SimonWoolf